[webkit-reviews] review denied: [Bug 63093] beginTransparencyLayer leaves context color out of sync, bleeds color into text : [Attachment 98060] Patch

Tue Jun 21 15:01:17 PDT 2011

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 63093: beginTransparencyLayer leaves context color out of sync, bleeds
color into text
https://bugs.webkit.org/show_bug.cgi?id=63093

Attachment 98060: Patch
https://bugs.webkit.org/attachment.cgi?id=98060&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98060&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:901
>      CGContextSaveGState(context);

save() calls CGContextSaveGState() so you can remove that.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:918
>      CGContextRestoreGState(context);
>      m_data->endTransparencyLayer();
>      m_data->m_userToDeviceTransformKnownToBeIdentity = false;
> +
> +    restore();

restore() calls restorePlatformState() which calls both
CGContextRestoreGState() and does
m_data->m_userToDeviceTransformKnownToBeIdentity = false so you can remove
those lines.

> LayoutTests/compositing/color-matching/color-leakage.html:16
> +<html>
> +  <head>
> +    <style>
> +	 div {
> +	   color: black;
> +	   border-top: 1px solid blue;
> +	   border-bottom: 1px solid rgba(0,0,0,0.9);
> +	 }
> +    </style>
> +</head>
> +<body>
> +    <div>
> +	   This should be black
> +  </div>
> +</body>
> +</html>

This test needs to be changed to make the pixel failure more detectable (larger
text, use Ahem etc).