[webkit-reviews] review granted: [Bug 61947] AudioContext needs non-blocking call to create AudioBuffer from audio file data : [Attachment 97669] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 14:24:26 PDT 2011


Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 61947: AudioContext needs non-blocking call to create AudioBuffer from
audio file data
https://bugs.webkit.org/show_bug.cgi?id=61947

Attachment 97669: Patch
https://bugs.webkit.org/attachment.cgi?id=97669&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
This looks good to me modulo the FIXMEs. You can easily give yourself the
ability to raise an exception from decodeAudioData by adding
"raises(DOMException)" to the IDL. Using one of the pre-defined exception codes
is easy; a custom exception requires custom bindings.


More information about the webkit-reviews mailing list