[webkit-reviews] review denied: [Bug 63054] IndexedDB: createObjectStore() should check if keypath is valid : [Attachment 97947] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 13:25:56 PDT 2011


Tony Chang <tony at chromium.org> has denied Kentaro Hara <haraken at google.com>'s
request for review:
Bug 63054: IndexedDB: createObjectStore() should check if keypath is valid
https://bugs.webkit.org/show_bug.cgi?id=63054

Attachment 97947: Patch
https://bugs.webkit.org/attachment.cgi?id=97947&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97947&action=review

> Source/WebCore/ChangeLog:11
> +	   if the |keypath| is invalid. With this parsing, we remove
keypath-as-array.html because
> +	   the current keypath parser does not support an array of keypath and
(more importantly)
> +	   the current implementation of ObjectStore does not support multiple
keypaths.

Can we add a new test that demonstrates that we don't support these keypath
values and that the right exception is raised?


More information about the webkit-reviews mailing list