[webkit-reviews] review denied: [Bug 63081] [GTK] [WK2] Fix for getting editor client commands. : [Attachment 98017] Keyboard event patch 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 11:41:18 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied Lukasz Slachciak
<l.slachciak at samsung.com>'s request for review:
Bug 63081: [GTK] [WK2] Fix for getting editor client commands.
https://bugs.webkit.org/show_bug.cgi?id=63081

Attachment 98017: Keyboard event patch 1
https://bugs.webkit.org/attachment.cgi?id=98017&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
Just removing the ASSERT is incorrect here. What type of events are passed to
this function? If it's only KeyDown and KeyUp we need a comment explaining why
a native  KeyUp event is equivalent to a DOM keypress event. The ASSERT should
be updated, since the following line only handles two types of events.


More information about the webkit-reviews mailing list