[webkit-reviews] review granted: [Bug 62848] Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port. : [Attachment 97925] Patch for comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 21 11:03:28 PDT 2011
Martin Robinson <mrobinson at webkit.org> has granted EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 62848: Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to
use in the EFL port.
https://bugs.webkit.org/show_bug.cgi?id=62848
Attachment 97925: Patch for comments
https://bugs.webkit.org/attachment.cgi?id=97925&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97925&action=review
Okay. Are you a committer. Can you make the following change before
committing?
> Source/WebCore/platform/graphics/cairo/CairoUtilities.h:50
> +void copyRectFromOneSurfaceToAnother(cairo_surface_t*, cairo_surface_t*,
const IntSize&, const IntRect&);
Here it makes sense to leave the argument names since it's unclear which is the
destination and which is the source.
More information about the webkit-reviews
mailing list