[webkit-reviews] review granted: [Bug 57085] SVG no fallback to discrete animation on attribute 'values' for SVGString : [Attachment 97993] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 57085: SVG no fallback to discrete animation on attribute 'values' for
SVGString
https://bugs.webkit.org/show_bug.cgi?id=57085

Attachment 97993: Patch
https://bugs.webkit.org/attachment.cgi?id=97993&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97993&action=review

Overall LGTM but the HashSet thing needs to be cleared up... After talking with
Dirk, this would be a small win if any and more confusing code. So only the
ChangeLog entry can be a bit improved, but r=me.

>> Source/WebCore/ChangeLog:12
>> +	    for strings anymore. Let CSS parser handle inheritance itself if we
don't have proceeding animations.
> 
> You may want to rephrase the "proceeding animations" bit.

You may want to rephrase the "proceeding animations" bit.