[webkit-reviews] review granted: [Bug 62867] Update GraphicsContextSkia when the Chromium platform is Mac : [Attachment 97988] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 10:31:08 PDT 2011


Eric Seidel <eric at webkit.org> has granted Cary Clark <caryclark at google.com>'s
request for review:
Bug 62867: Update GraphicsContextSkia when the Chromium platform is Mac
https://bugs.webkit.org/show_bug.cgi?id=62867

Attachment 97988: Patch
https://bugs.webkit.org/attachment.cgi?id=97988&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97988&action=review

This looks much nicer.	Thank you.

> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:579
> +    const SkScalar focusRingOutset = getFocusRingOutset(width);

WebKit style doesn't use "get" in method names.


More information about the webkit-reviews mailing list