[webkit-reviews] review denied: [Bug 63073] Adding version of fast/events/offsetX-offsetY.html without text run or line height deps : [Attachment 97994] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 21 10:14:12 PDT 2011
Simon Fraser (smfr) <simon.fraser at apple.com> has denied review:
Bug 63073: Adding version of fast/events/offsetX-offsetY.html without text run
or line height deps
https://bugs.webkit.org/show_bug.cgi?id=63073
Attachment 97994: Patch
https://bugs.webkit.org/attachment.cgi?id=97994&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97994&action=review
> LayoutTests/fast/events/document-elementFromPoint.html:216
> + document.body.ontouchstart = function(e) {
> + var touch = e.touches[0];
> + var resultBox = document.getElementById('mouse-position');
> + var clientRect = e.target.getBoundingClientRect();
> + var offsets = 'element id: ' + e.target.id + '<br>';
> + offsets += 'clientX: ' + touch.clientX + ' clientY: ' +
touch.clientY + '<br>';
> + offsets += '~offsetX: ' + (clientRect.left - touch.clientX) + '
~offsetY: ' + (clientRect.top - touch.clientY);
> + resultBox.innerHTML = offsets;
> + // Do not prevent default, so we can scroll.
> + }
Remove this.
More information about the webkit-reviews
mailing list