[webkit-reviews] review denied: [Bug 62209] All pointer-events fail if text has visibility="hidden" : [Attachment 97995] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 62209: All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209

Attachment 97995: Patch
https://bugs.webkit.org/attachment.cgi?id=97995&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97995&action=review

Great that you're working on this, r- because of:

> Source/WebCore/rendering/InlineTextBox.cpp:362
> +    PointerEventsHitRules::EHitTesting hitTesting =
PointerEventsHitRules::HTML_HITTESTING;
> +#if ENABLE(SVG)
> +    if (isSVGInlineTextBox())
> +	   hitTesting = PointerEventsHitRules::SVG_TEXT_HITTESTING;
> +#endif
> +    PointerEventsHitRules hitRules(hitTesting, request,
renderer()->style()->pointerEvents());

Does HTML really want to use the pointer-events codepath? What for?
Why not override nodeAtPoint in SVGInlineTextBox and handling pointer-events
there, just like it's done for all non-text renderers, that support
pointer-events.

> LayoutTests/svg/custom/intersection-list-nested-svg.svg:1
> +<?xml version="1.0" encoding="UTF-8"?>

This test looks unrelated.