[webkit-reviews] review denied: [Bug 63055] Web Inspector: Feature Request: Able to remove all breakpoints : [Attachment 97981] [patch] second version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 63055: Web Inspector: Feature Request: Able to remove all breakpoints
https://bugs.webkit.org/show_bug.cgi?id=63055

Attachment 97981: [patch] second version
https://bugs.webkit.org/attachment.cgi?id=97981&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97981&action=review

r- per Pavel's comment. I also think that introducing a new method that simply
wipes out all breakpoints from the VM would be more reliable (i.e. remove all
from VM instead of iterating over the map in the agent).

> Source/WebCore/inspector/Inspector.json:1465
> +		   "parameters": [

no need to declare parameters.