[webkit-reviews] review canceled: [Bug 61726] [CSS Exclusions] Parse wrap-shape property : [Attachment 96229] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 07:52:45 PDT 2011


Chiculita Alexandru <achicu at adobe.com> has canceled Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 61726: [CSS Exclusions] Parse wrap-shape property
https://bugs.webkit.org/show_bug.cgi?id=61726

Attachment 96229: Patch
https://bugs.webkit.org/attachment.cgi?id=96229&action=review

------- Additional Comments from Chiculita Alexandru <achicu at adobe.com>
- Created pure JS test
- Renamed Shape.h/cpp to CSSWrapShapes.h/cpp
- Renamed class Shape to CSSWrapShape. Also its friends are renamed to
CSSWrapShapeRect, CSSWrapShapeCircle, CSSWrapShapeEllipse and
CSSWrapShapePolygon
- Uses the pre-processing of the CSSPropertyNames.in and CSSValueKeywords.in.
That is added in https://bugs.webkit.org/show_bug.cgi?id=62114 which was
reviewed, but is not yet in trunk, so this is why the build-bot should have
failed.

Because the CSSWrapShapePolygon needs evenodd and nonzero, I moved that enum
from Path.h to its own WindRule.h file. Evenodd and nonzero are keywords used
by both SVG and Wrap Shapes. Because of that I had to add that #if in
SVGCSSValueKeywords.in


More information about the webkit-reviews mailing list