[webkit-reviews] review canceled: [Bug 62954] add/removeSpellcheckRange use RefPtr incorrectly for arguments : [Attachment 97783] A quick patch v0

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has canceled Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 62954: add/removeSpellcheckRange use RefPtr incorrectly for arguments
https://bugs.webkit.org/show_bug.cgi?id=62954

Attachment 97783: A quick patch v0
https://bugs.webkit.org/attachment.cgi?id=97783&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings Darin,

(In reply to comment #2)
> (From update of attachment 97783 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=97783&action=review
> 
> > Source/WebCore/dom/DocumentMarkerController.cpp:686
> > +bool DocumentMarkerController::addUserSpellingMarker(Node* node, unsigned
start, unsigned length, PassRefPtr<DOMStringList> srcSuggestions, unsigned
options)
> 
> The prefix we use here is “prp”, not “src”.

Thank you for noticing it. (I'm a little wondering why check-webkit-style did
not notice it, though. It may be a good idea to write a change for it?) I have
updated this change to use prp prefixes for PassRefPtr arguments. Is it
possible to review the updated one?

Regards,

Hironori Bono