[webkit-reviews] review granted: [Bug 61572] KURL::protocolIs(const char* protocol) asserts in Debug builds with valid protocols : [Attachment 97894] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 61572: KURL::protocolIs(const char* protocol) asserts in Debug builds with
valid protocols
https://bugs.webkit.org/show_bug.cgi?id=61572

Attachment 97894: Patch
https://bugs.webkit.org/attachment.cgi?id=97894&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97894&action=review

Is the isLetterMatchIgnoringCase function used anywhere else? If not, then we
probably should remove it.

> Source/WebCore/platform/KURL.cpp:249
> +    ASSERT(isSchemeChar(character));
> +    ASSERT(isASCIILower(schemeCharacter) || (!isASCIIUpper(schemeCharacter)
&& isSchemeChar(schemeCharacter)));
> +    return (character | 0x20) == schemeCharacter;

I think we want another assertion:

    ASSERT(schemeCharacter & 0x20);