[webkit-reviews] review requested: [Bug 63029] Fix legacy color attribute parsing to match HTML spec : [Attachment 97893] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 63029: Fix legacy color attribute parsing to match HTML spec
https://bugs.webkit.org/show_bug.cgi?id=63029

Attachment 97893: Patch
https://bugs.webkit.org/attachment.cgi?id=97893&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97893&action=review

Do we know of any colors that IE used to parse, that will now fail?

> LayoutTests/fast/dom/script-tests/attribute-legacy-colors.js:3
>
+shouldBe("document.body.bgColor='';getComputedStyle(document.body).backgroundC
olor;", "'rgba(0, 0, 0, 0)'");

Wedging the getComputedStyle() in there is pretty ugly. There has to be a
better way to write these shouldBe()s.
Would be nice to make this series of tests data driven with a loop.