[webkit-reviews] review granted: [Bug 62833] Arrow keys don't move caret properly in vertical writing modes : [Attachment 97661] fixes the bug
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 20 16:34:51 PDT 2011
Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 62833: Arrow keys don't move caret properly in vertical writing modes
https://bugs.webkit.org/show_bug.cgi?id=62833
Attachment 97661: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=97661&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
This seems awkward. The flag name is precise, but mechanical. Seems like
readers will understand the other arguments to modify and be puzzled by this
one. The concept of “swapping” is not quite the right way to describe the fact
that turning things 90 degrees might change what the direction means.
Despite all of that I have no specific better suggestion, so r=me
More information about the webkit-reviews
mailing list