[webkit-reviews] review denied: [Bug 62396] Web Inspector: [Chromium] Successfully prefetched page shows up as an error in console : [Attachment 97782] Patch with new field renamed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 20 13:52:01 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 62396: Web Inspector: [Chromium] Successfully prefetched page shows up as
an error in console
https://bugs.webkit.org/show_bug.cgi?id=62396

Attachment 97782: Patch with new field renamed
https://bugs.webkit.org/attachment.cgi?id=97782&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97782&action=review

> Source/WebKit/chromium/public/WebURLError.h:55
> +    // A flag showing whether this error should be trated as a cancellation,


"trated" -> "treated"

> Source/WebKit/chromium/src/WebURLError.cpp:65
> +    ResourceError resourceError = ResourceError(domain, reason,

note: the old code aligned the parameters in a right-aligned column.
you should probably indent the 2nd and 3rd params to preserve that
style.


More information about the webkit-reviews mailing list