[webkit-reviews] review granted: [Bug 62940] Disallow assigning into PassOwnArrayPtr, PassOwnPtr and PassRefPtr : [Attachment 97842] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 20 12:50:09 PDT 2011


Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 62940: Disallow assigning into PassOwnArrayPtr, PassOwnPtr and PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=62940

Attachment 97842: Patch
https://bugs.webkit.org/attachment.cgi?id=97842&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97842&action=review

> Source/WebCore/editing/htmlediting.cpp:892
> +    RefPtr<Node> tabTextNode = prpTabTextNode;

I would have put this at the top of the function instead of here.


More information about the webkit-reviews mailing list