[webkit-reviews] review requested: [Bug 5566] ALT attribute value sometimes not displayed when image is missing : [Attachment 97839] Fix the image rendering sizing so that broken image icon and alt text will be displayed when they are avaiable

[bugzilla-daemon at webkit.org]

Joe Wild <joseph.wild at nokia.com> has asked  for review:
Bug 5566: ALT attribute value sometimes not displayed when image is missing
https://bugs.webkit.org/show_bug.cgi?id=5566

Attachment 97839: Fix the image rendering sizing so that broken image icon and
alt text will be displayed when they are avaiable
https://bugs.webkit.org/attachment.cgi?id=97839&action=review

------- Additional Comments from Joe Wild <joseph.wild at nokia.com>
This is a fairly big issue so I am taking a phased approach.
This 1st submittal is just to get the current code to work as it
I think it was intended.  I basically attempted to fix the sizing
code so that the alt text could be displayed.

Once design decision I did make was to show the border box, with the
broken image icon in the upper left corner followed by the alternate text.
The original code would show the border box with the broken image icon
in the center and the alternate text in the upper left corner.

I had to redo the results of several tests now that the sizing and display
of alt text are different.  I only updated the results on the platform
I have convenient access to (QtWebkit Linux).  Please let me know if
I need to update results on other platforms.  I will have to see if I
can get access to them.

This is a large patch, but it is mostly a couple of new tests and new
results files.