[webkit-reviews] review requested: [Bug 63004] [Qt] Regression(60942) wrong default action for drag-and-drop. : [Attachment 97836] Patch.

[bugzilla-daemon at webkit.org]

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 63004: [Qt] Regression(60942) wrong default action for drag-and-drop.
https://bugs.webkit.org/show_bug.cgi?id=63004

Attachment 97836: Patch.
https://bugs.webkit.org/attachment.cgi?id=97836&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Added special handling for the case that dragOperation is not initialized.
Save the last dropOperation and pass it to the dropEvent, so that it can be
accepted by QDrag.
Call event->accepted() and not event->acceptProposedAction(), because the later
ignores the dropAction specified in JavaScript.

Tested with the test page attached to
https://bugs.webkit.org/show_bug.cgi?id=40401 and did not see any issue.
Also manually tested all combinations of
LayoutTests/fast/events/drag-and-drop.html and they all pass.