[webkit-reviews] review denied: [Bug 62027] nrwt: handle missing httpd cleanly : [Attachment 97798] proposed fix

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Kristóf Kosztyó
<Kosztyo.Kristof at stud.u-szeged.hu>'s request for review:
Bug 62027: nrwt: handle missing httpd cleanly
https://bugs.webkit.org/show_bug.cgi?id=62027

Attachment 97798: proposed fix
https://bugs.webkit.org/attachment.cgi?id=97798&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97798&action=review

> Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py:211
> +

You don't need this function. Use self._port_obj._path_to_apache() (see line 78
for an example).

> Tools/Scripts/webkitpy/layout_tests/port/base.py:192
> +	       self.check_httpd()

This should just return False if there's no httpd, not raise an Exception.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:240
> +	       raise Exception('No httpd found. Cannot run http tests.')

This should not raise an exception. Just return the result of has_httpd(). In
fact, I would probably just inline that method, which made more sense as a
separate method when it was on the http_server object.

> Tools/Scripts/webkitpy/layout_tests/port/http_server.py:107
> +

Same comment as above.