[webkit-reviews] review granted: [Bug 62889] Add Font interface to support Skia on Mac Chrome port : [Attachment 97801] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 20 11:13:23 PDT 2011
Eric Seidel <eric at webkit.org> has granted Cary Clark <caryclark at google.com>'s
request for review:
Bug 62889: Add Font interface to support Skia on Mac Chrome port
https://bugs.webkit.org/show_bug.cgi?id=62889
Attachment 97801: Patch
https://bugs.webkit.org/attachment.cgi?id=97801&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97801&action=review
OK.
> Source/WebCore/platform/graphics/skia/FontSkia.cpp:88
> + SkTypeface* typeface =
SkCreateTypefaceFromCTFont(platformData.ctFont());
> + SkAutoUnref autoUnref(typeface);
I take it skia smart pointers don't work like webkit (or boost) ones with a
.get() method? If so, then there is no need to have a separate raw pointer.
More information about the webkit-reviews
mailing list