[webkit-reviews] review canceled: [Bug 62932] FrameSelection::modify should take verticalDisplacement instead of verticalDistance : [Attachment 97816] renamed the argument

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 20 10:03:29 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 62932: FrameSelection::modify should take verticalDisplacement instead of
verticalDistance
https://bugs.webkit.org/show_bug.cgi?id=62932

Attachment 97816: renamed the argument
https://bugs.webkit.org/attachment.cgi?id=97816&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
On my second thought, it's probably cleaner to add VerticalDirection enum
because callers compute distance and then pass distance or -distance depending.


More information about the webkit-reviews mailing list