[webkit-reviews] review granted: [Bug 55308] [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher. : [Attachment 97700] General mechanism for adjusting WebKitWebSettings in GtkLauncher

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 20 09:22:57 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Lukasz Slachciak
<l.slachciak at samsung.com>'s request for review:
Bug 55308: [GTK] General mechanism for adjusting WebKitWebSettings in
GtkLauncher.
https://bugs.webkit.org/show_bug.cgi?id=55308

Attachment 97700: General mechanism for adjusting WebKitWebSettings in
GtkLauncher
https://bugs.webkit.org/attachment.cgi?id=97700&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97700&action=review

Nice work! I'll land this one.

> Tools/GtkLauncher/main.c:280
> +	   return NULL;

You should use 0 here instead of NULL.

> Tools/GtkLauncher/main.c:285
> +	   return NULL;

Ditto.

> Tools/GtkLauncher/main.c:359
> +    GError *error = NULL;

You should use 0 instead of NULL unless you are ending an argument list. I'll
fix this and land.


More information about the webkit-reviews mailing list