[webkit-reviews] review granted: [Bug 61774] ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com : [Attachment 97770] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 61774: ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting
www.nba.com
https://bugs.webkit.org/show_bug.cgi?id=61774

Attachment 97770: Patch
https://bugs.webkit.org/attachment.cgi?id=97770&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97770&action=review

> LayoutTests/fast/parser/attributes-on-close-script.html:2
> +<script class="value">

Do we actually need the attribute on opening tag? It makes the test slightly
confusing (does it matter that the opening tag has an attribute? does it need
to be the same on opening and closing tags?)

> LayoutTests/fast/parser/attributes-on-close-script.html:3
> +alert('PASS');

This is testing for an assertion failure, so test content or output should
explain that ("PASS if no assertion failure occurred" would be sufficient).