[webkit-reviews] review granted: [Bug 62985] Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu. : [Attachment 97795] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 20 07:12:59 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 62985: Web Inspector: introduce InspectorFrontendAPI for actions initiated
from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985

Attachment 97795: Patch
https://bugs.webkit.org/attachment.cgi?id=97795&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97795&action=review

> Source/WebCore/inspector/InspectorFrontendClientLocal.cpp:221
> +    ScriptValue value =
m_frontendPage->mainFrame()->script()->executeScript(expression);

Some ifs are missing.

> Source/WebKit/mac/WebInspector/WebInspector.mm:78
>	   page->inspectorController()->showConsole();

This should go through inspector frontend API.


More information about the webkit-reviews mailing list