[webkit-reviews] review granted: [Bug 62942] [GTK] ASSERTION FAILED: it != gFontDataCache->end() in FontCache.cpp:318 : [Attachment 97755] Patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 62942: [GTK] ASSERTION FAILED: it != gFontDataCache->end() in
FontCache.cpp:318
https://bugs.webkit.org/show_bug.cgi?id=62942

Attachment 97755: Patch
https://bugs.webkit.org/attachment.cgi?id=97755&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97755&action=review

Alright, this hasn't crashed on me in 2+ hours, so clearly it must be an
improvement. I think I miss a detailed explanation of why using FcPatternEqual
somehow breaks the distinction between deleted and null font stuff in the
ChangeLog, though.

> Source/WebCore/ChangeLog:8
> +	   Fix thee == operator overload of the FreeType FontPlatformData to
properly make the

s/thee/the/