[webkit-reviews] review requested: [Bug 62954] add/removeSpellcheckRange use RefPtr incorrectly for arguments : [Attachment 97783] A quick patch v0
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 20 05:19:53 PDT 2011
Hironori Bono <hbono at chromium.org> has asked for review:
Bug 62954: add/removeSpellcheckRange use RefPtr incorrectly for arguments
https://bugs.webkit.org/show_bug.cgi?id=62954
Attachment 97783: A quick patch v0
https://bugs.webkit.org/attachment.cgi?id=97783&action=review
------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,
(In reply to comment #0)
> Arguments should be PassRefPtr or raw pointers, never RefPtr.
Thank you for noticing it. I have replaced all the RefPtr arguments in my
r88332: <http://trac.webkit.org/changeset/88332> with PassRefPtr. (Even though
I have not tried this change on valgrind, I think this change works without
memory leaks.) It would be definitely helpful to give me feedback.
Regards,
Hironori Bono
More information about the webkit-reviews
mailing list