[webkit-reviews] review denied: [Bug 62863] [Qt] Orientation sensor is always on, which has negative impact on battery life. : [Attachment 97638] provide API in qwebframe to give qtwebkit client option to start/stop sensors

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Fabrizio
<fabrizio.machado at nokia.com>'s request for review:
Bug 62863: [Qt] Orientation sensor is always on, which has negative impact on
battery life.
https://bugs.webkit.org/show_bug.cgi?id=62863

Attachment 97638: provide API in qwebframe to give qtwebkit client option to
start/stop sensors
https://bugs.webkit.org/attachment.cgi?id=97638&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97638&action=review

> Source/WebKit/qt/Api/qwebframe.h:203
> +    void stopOrientationSensor() const;
> +    void startOrientationSensor() const;

'const' does not make semantic sense for these methods, as they alter the state
of the object.
Also, for internal methods, we typically do something like:

void QWEBKIT_EXPORT qtwebkit_webframe_setOrientationSensorEnabled(QWebFrame*
frame, bool enabled)

(This goes in the cpp file to avoid polluting public headers with internal
API.)