[webkit-reviews] review denied: [Bug 18450] SVG animation flickers when restarting : [Attachment 97126] Patch for SVG animation flickers when restarting
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 18 22:58:04 PDT 2011
Dirk Schulze <krit at webkit.org> has denied Felician Marton
<marton.felician.zoltan at stud.u-szeged.hu>'s request for review:
Bug 18450: SVG animation flickers when restarting
https://bugs.webkit.org/show_bug.cgi?id=18450
Attachment 97126: Patch for SVG animation flickers when restarting
https://bugs.webkit.org/attachment.cgi?id=97126&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
Patch looks great! We need regression tests for changes like that. Sadly I
don't know a way how to test. Maybe with SVGSVGElements getCurrentTime()? Can
you check this? Anyway, even if there is no way to test it, this needs to be
noted in the changelog. But please try to find a way first.
More information about the webkit-reviews
mailing list