[webkit-reviews] review granted: [Bug 62679] Add notify handler to trigger MemoryPressureHandler in all builds : [Attachment 97703] Updated patch using notify

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 62679: Add notify handler to trigger MemoryPressureHandler in all builds
https://bugs.webkit.org/show_bug.cgi?id=62679

Attachment 97703: Updated patch using notify
https://bugs.webkit.org/attachment.cgi?id=97703&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97703&action=review

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:55
> +static int notifyToken;

This can go inside the function where it’s used instead of at the file level.

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:72
> +    notify_register_dispatch("com.apple.WebKit.lowMemory", &notifyToken,
> +				dispatch_get_main_queue(), ^(int) {
memoryPressureHandler().respondToMemoryPressure();});

This is not WebKit project style indentation. We don't line up things with
parentheses on the line before

I suggest "org.WebKit.lowMemory" instead of "com.apple.WebKit.lowMemory".