[webkit-reviews] review denied: [Bug 62613] No context for javascript parse errors. : [Attachment 97682] updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 17 19:14:09 PDT 2011
Oliver Hunt <oliver at apple.com> has denied Juan C. Montemayor
<jmont at apple.com>'s request for review:
Bug 62613: No context for javascript parse errors.
https://bugs.webkit.org/show_bug.cgi?id=62613
Attachment 97682: updated patch
https://bugs.webkit.org/attachment.cgi?id=97682&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97682&action=review
Noooooooooooooo -- r- due to those tests that have bogus changes (listed below)
> LayoutTests/fast/js/cyclic-proto-expected.txt:1
> +posix_spawn fatal error: 9!
This looks bogus
> LayoutTests/http/tests/media/pdf-served-as-pdf-expected.txt:-5
> +posix_spawn fatal error: 9!
> +FAIL: Timed out waiting for notifyDone to be called
> EXPECTED (video.error == 'null') OK
> EVENT(loadstart)
> -EVENT(error)
> -failed trying to load PDF file served as PDF OK
> -END OF TEST
bogus change
> LayoutTests/http/tests/media/reload-after-dialog-expected.txt:3
> +posix_spawn fatal error: 9!
> +FAIL: Timed out waiting for notifyDone to be called
Bogus change
More information about the webkit-reviews
mailing list