[webkit-reviews] review granted: [Bug 62920] JSONP is unnecessarily slow : [Attachment 97677] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 62920: JSONP is unnecessarily slow
https://bugs.webkit.org/show_bug.cgi?id=62920

Attachment 97677: Patch
https://bugs.webkit.org/attachment.cgi?id=97677&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97677&action=review

R+, with changes above.

> Source/JavaScriptCore/interpreter/Interpreter.cpp:766
> +	       JSValue baseObject(globalObject);

Please either (1) make this throw the correct errors, or (2) file a bug, add a
comment with the bug number here.

> Source/JavaScriptCore/runtime/LiteralParser.cpp:227
> +	       return TokAssign;

TokSemi!

> Source/JavaScriptCore/runtime/LiteralParser.cpp:230
> +	       while (m_ptr < m_end && (isASCIIAlphanumeric(*m_ptr) || *m_ptr
== '_' || *m_ptr == '$'))

I think this while loop is double-checking the identifier start? - not a bug
per se, but I think you could add an increment to m_ptr prior to the while &
skip a redundant check.