[webkit-reviews] review granted: [Bug 61942] [EFL] Add ImageDiff implementation. : [Attachment 97642] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 61942: [EFL] Add ImageDiff implementation.
https://bugs.webkit.org/show_bug.cgi?id=61942

Attachment 97642: Patch
https://bugs.webkit.org/attachment.cgi?id=97642&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97642&action=review

Thank you.

> Tools/DumpRenderTree/efl/ImageDiff.cpp:80
> +	       diffPixel[Red] = diffPixel[Green] = diffPixel[Blue] = *buffer++;


Oh, this is nice.  thank you.

> Tools/DumpRenderTree/efl/ImageDiff.cpp:100
> +    const float red = computeDistanceBetweenPixelComponents(actualPixel,
basePixel, Red);

Very nice!

> Tools/DumpRenderTree/efl/ImageDiff.cpp:118
> +    OwnArrayPtr<unsigned char> diffBuffer = adoptArrayPtr(new unsigned
char[width * height]);

I might have typedefed unsigned char given how often you're typing it in this
file.  But this looks fine.