[webkit-reviews] review requested: [Bug 62599] Errors encountered within SVG documents should be reported to the console : [Attachment 97625] 0001 - Add SVGElement::reportAttributeParsingError

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has asked  for review:
Bug 62599: Errors encountered within SVG documents should be reported to the
console
https://bugs.webkit.org/show_bug.cgi?id=62599

Attachment 97625: 0001 - Add SVGElement::reportAttributeParsingError
https://bugs.webkit.org/attachment.cgi?id=97625&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
(In reply to comment #40)
> These don't include the document URI, I guess these results are old?

1. Patches 2/3/4 are very old, I'll update them (probably one at a time) once 1
gets through.

2. However, the document URI doesn't seem to get printed there (?!?). It shows
up in Web Inspector! Just not in that output. Or maybe there's something
different about those documents? I'll take a look in a bit.

> In general this looks good, though r- as SVGParsingError.h is superfluous,
> just move it into SVGElement.h. I agree with Darin.

Ok, I've fixed that too.