[webkit-reviews] review granted: [Bug 62831] [Chromium] Add WebDocument APIs for the functions moving from WebFrame : [Attachment 97516] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 62831: [Chromium] Add WebDocument APIs for the functions moving from
WebFrame
https://bugs.webkit.org/show_bug.cgi?id=62831

Attachment 97516: Patch
https://bugs.webkit.org/attachment.cgi?id=97516&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97516&action=review

> Source/WebCore/dom/Document.cpp:3952
> +    // FIXME: Why do only top-level frames have openSearchDescriptionURLs?

If this condition matters to Chromium, then I think we should move it to
Chromium.
It definitely doesn't make sense here.

> Source/WebCore/dom/Document.cpp:3956
> +    // FIXME: Why do we need to wait for FrameStateComplete?

I don't know the history of this check, but if Chromium cares to know the
loading state before querying this field,
then that also seems like something Chromium should do on its own.