[webkit-reviews] review denied: [Bug 62703] Web Inspector: [Qt] almost all styles tests are flaky : [Attachment 97618] [patch] second version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 62703: Web Inspector: [Qt] almost all styles tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=62703

Attachment 97618: [patch] second version
https://bugs.webkit.org/attachment.cgi?id=97618&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97618&action=review

> LayoutTests/inspector/styles/styles-add-invalid-property.html:13
> +	   InspectorTest.addSniffer(WebInspector.StylesSidebarPane.prototype,
"_rebuildUpdate", step0);

I don't see why this dispatch is necessary. _rebuildUpdate sniffer should take
care of things. I thought we agreed to force synchronous styles recalc. You
could make a utility showElementsPanelAndUpdateStyles method for that.

> LayoutTests/inspector/styles/styles-update-from-js.html:45
> +console.trace();

This is probably not intentional

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:241
> +    _reloadAllStylesDelayed: function()

_reloadAllStyles

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:254
> +    _reloadAllStyles: function()

_scheduleReloadAllStyles