[webkit-reviews] review granted: [Bug 62114] "WebCore/css/makeprop.pl" and "WebCore/css/makevalues.pl" should take ENABLE_ flags into account : [Attachment 97563] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 62114: "WebCore/css/makeprop.pl" and "WebCore/css/makevalues.pl" should
take ENABLE_ flags into account
https://bugs.webkit.org/show_bug.cgi?id=62114

Attachment 97563: Patch
https://bugs.webkit.org/attachment.cgi?id=97563&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97563&action=review

> Source/WebCore/CMakeLists.txt:2193
> +    COMMAND cat ${WebCore_CSS_PROPERTY_NAMES} >
${DERIVED_SOURCES_WEBCORE_DIR}/CSSPropertyNames.in

I would probably use cp, but cat seems OK too.

> Source/WebCore/WebCore.gyp/scripts/action_csspropertynames.py:129
> +    # Concatenate all the input files

Nit: Add a period to the end of this comment.

> Source/WebCore/WebCore.gyp/scripts/action_cssvaluekeywords.py:133
> +    # Concatenate all the input files

Nit: Add a period.

> Source/WebCore/css/makeprop.pl:27
>  use strict;
>  use warnings;
> +use Getopt::Long;
> +use preprocessor;

Nit: Sort these alphabetically.

> Source/WebCore/css/makevalues.pl:27
>  use strict;
>  use warnings;
> +use Getopt::Long;
> +use preprocessor;

Nit: alphabetize

> Source/WebCore/css/makevalues.pl:44
> +  # CSS values need to be lower case

Nit: Add a period.