[webkit-reviews] review granted: [Bug 62846] Detect mixed-scripting involving https -> http redirects : [Attachment 97607] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 17 09:36:43 PDT 2011


Adam Barth <abarth at webkit.org> has granted Chris Evans <cevans at google.com>'s
request for review:
Bug 62846: Detect mixed-scripting involving https -> http redirects
https://bugs.webkit.org/show_bug.cgi?id=62846

Attachment 97607: Patch
https://bugs.webkit.org/attachment.cgi?id=97607&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97607&action=review

This isn't a complete solution, but it's a good step forward.

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:202
> +bool CachedResourceLoader::checkMixedContent(CachedResource::Type type,
const KURL& url) const

I'd call this function checkInsecureContent to be consistent with the other
terminology we're using.


More information about the webkit-reviews mailing list