[webkit-reviews] review granted: [Bug 59085] Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts : [Attachment 97591] Patch v12

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 59085: Integrate SVG Fonts within GlyphPage concept, removing the special
SVG code paths from Font, making it possible to reuse the simple text code path
for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Attachment 97591: Patch v12
https://bugs.webkit.org/attachment.cgi?id=97591&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97591&action=review

Looks great, just check whether you have all test results included and of
course that there are no regressions. r=me

> Source/WebCore/ChangeLog:38
> +	   * features.pri: Temporarily turn of SVG Fonts for Qt, as long as
QRawFont support is not available and the fast path is disabled.

Turn off

> Source/WebCore/platform/graphics/TextRun.h:121
>	   virtual ~RenderingContext() { }

It is a bit strange that this class name is generic but has SVG specific
methods. But not needed for this patch to fix that.

> LayoutTests/ChangeLog:79
> +	   * svg/custom/svg-fonts-fallback.xhtml: Added.

Are some test results like for this one missing?