[webkit-reviews] review denied: [Bug 62856] Web Inspector: use stack trace to create anchors for console messages. : [Attachment 97580] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 17 05:04:49 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 62856: Web Inspector: use stack trace to create anchors for console
messages.
https://bugs.webkit.org/show_bug.cgi?id=62856

Attachment 97580: Patch.
https://bugs.webkit.org/attachment.cgi?id=97580&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97580&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:787
> +	       var urlElement =
WebInspector.linkifyCallFrameAsNode(this._stackTrace[0],
"console-message-url");

using this.url and this.line should work equally well, what's the point in
using top frame here?


More information about the webkit-reviews mailing list