[webkit-reviews] review denied: [Bug 62809] [Qt] [WK2] Support undo/redo in MiniBrowser : [Attachment 97482] fix patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Chang Shu <cshu at webkit.org>'s
request for review:
Bug 62809: [Qt] [WK2] Support undo/redo in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=62809

Attachment 97482: fix patch
https://bugs.webkit.org/attachment.cgi?id=97482&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97482&action=review

> Source/WebKit2/UIProcess/API/qt/qwkpage.h:131
> +    bool isModified() const;
> +#ifndef QT_NO_UNDOSTACK
> +    QUndoStack* undoStack() const;
> +#endif

undoStack() should be replaced by d->undoStack inside QWKPage.
Why do we need isModified() and the 'modified' property?

> Tools/MiniBrowser/qt/BrowserWindow.cpp:89
> +    undo->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_Z));

Use the QKeySequence constructor that takes a StandardKey (QKeySequence::Undo
in this case.)

> Tools/MiniBrowser/qt/BrowserWindow.cpp:92
> +    redo->setShortcut(QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_Z));

Ditto (QKeySequence::Redo.)