[webkit-reviews] review denied: [Bug 62599] Errors encountered within SVG documents should be reported to the console : [Attachment 97502] 0001 - Add SVGElement::reportAttributeParsingError

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 17 03:06:53 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has denied Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 62599: Errors encountered within SVG documents should be reported to the
console
https://bugs.webkit.org/show_bug.cgi?id=62599

Attachment 97502: 0001 - Add SVGElement::reportAttributeParsingError
https://bugs.webkit.org/attachment.cgi?id=97502&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97502&action=review

> Source/WebCore/ChangeLog:26
> +	   * svg/SVGParsingError.h: Added.

In general this looks good, though r- as SVGParsingError.h is superfluous, just
move it into SVGElement.h. I agree with Darin.


More information about the webkit-reviews mailing list