[webkit-reviews] review requested: [Bug 59085] Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts : [Attachment 97567] Patch v10

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 17 02:50:39 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 59085: Integrate SVG Fonts within GlyphPage concept, removing the special
SVG code paths from Font, making it possible to reuse the simple text code path
for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Attachment 97567: Patch v10
https://bugs.webkit.org/attachment.cgi?id=97567&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
New day, new patch. Revert all win build hacks, none of them worked.
I just discovered that I forward declare WidthIterator/GlyphData using a
class-forward, but these are actually structs, maybe that confuses the win
linker.

This time I'm touching wtf/Platform.h, in order to not break Qt EWS again, I
_hope_ this time it will work.


More information about the webkit-reviews mailing list