[webkit-reviews] review granted: [Bug 61972] [GTK] Clean up unecessary boilerplate from WebKitWebSettings and make private members meet WebKit style guidelines : [Attachment 96678] Patch that does not use assign private data members in the copy constructor

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 61972: [GTK] Clean up unecessary boilerplate from WebKitWebSettings and
make private members meet WebKit style guidelines
https://bugs.webkit.org/show_bug.cgi?id=61972

Attachment 96678: Patch that does not use assign private data members in the
copy constructor
https://bugs.webkit.org/attachment.cgi?id=96678&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96678&action=review

Looks reasonable to me.  If you need a real gtk reviewer you should ask one of
your gtk folks though. :)

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:906
> +    delete WEBKIT_WEB_SETTINGS(object)->priv;

Manual delete?	So sad!