[webkit-reviews] review denied: [Bug 62613] No context for javascript parse errors. : [Attachment 97535] hopefully final patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Juan C. Montemayor
<jmont at apple.com>'s request for review:
Bug 62613: No context for javascript parse errors.
https://bugs.webkit.org/show_bug.cgi?id=62613

Attachment 97535: hopefully final patch
https://bugs.webkit.org/attachment.cgi?id=97535&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97535&action=review

revert the project file change, did you verify all the tests pass now?	With
that done i believe everything is finished

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:2668
>			};
>			buildConfigurationList = 149C277108902AFE008A9EFC /*
Build configuration list for PBXProject "JavaScriptCore" */;
>			compatibilityVersion = "Xcode 3.1";
> -			developmentRegion = English;
>			hasScannedForEncodings = 1;
>			knownRegions = (
>				English,

Revert your changes to the project file

> Source/JavaScriptCore/parser/JSParser.cpp:387
> +	       errorMessage = "Unexpected EOF"; 
> +	       m_errorMessage = errorMessage.impl();
> +	       return;
> +	   case RETURN:
> +	       errorMessage = "Return statements are only valid inside
functions";
> +	       m_errorMessage = errorMessage.impl();

No reason to do these in two steps