[webkit-reviews] review requested: [Bug 62811] [filesystem/Chromium] Filesystem paths need proper URL escaping : [Attachment 97512] Make encodeWithURLEscapeSequences in KURLGoogle.cpp actually do what it says, then use it on filesystem paths.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 16 15:37:47 PDT 2011
Eric U. <ericu at chromium.org> has asked for review:
Bug 62811: [filesystem/Chromium] Filesystem paths need proper URL escaping
https://bugs.webkit.org/show_bug.cgi?id=62811
Attachment 97512: Make encodeWithURLEscapeSequences in KURLGoogle.cpp actually
do what it says, then use it on filesystem paths.
https://bugs.webkit.org/attachment.cgi?id=97512&action=review
------- Additional Comments from Eric U. <ericu at chromium.org>
This fixes KURLGoogle's encodeWithEscapeSequences, which was apparently
crippled due to a callsite that no longer exists. I've removed the obsolete
comments, made it actually escape, and used it in the filesystem code.
Tested by running the Blob layout tests. The blob URL code assumes that this
does some escaping, I believe, but so far the lack of it hasn't broken anything
[since the strings to be escaped didn't contain anything interesting]. This
change doesn't break anything either, as the escaping is harmless in those
cases.
More information about the webkit-reviews
mailing list