[webkit-reviews] review granted: [Bug 51941] refactor HTMLLinkElement to allow Link header implementation : [Attachment 97348] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 51941: refactor HTMLLinkElement to allow Link header implementation
https://bugs.webkit.org/show_bug.cgi?id=51941

Attachment 97348: Patch
https://bugs.webkit.org/attachment.cgi?id=97348&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97348&action=review

> Source/WebCore/html/LinkRelAttribute.cpp:48
> +	       {
> +	       }

Bad indent.

> Source/WebCore/html/LinkRelAttribute.cpp:52
> +    *this = tokenize(rel);

Crazy!	I would just make this a private member function rather than doing this
bizarre thing.	The one caller of this method can just use the constructor and
the assignment operator.

> Source/WebCore/html/LinkRelAttribute.h:54
> +    static LinkRelAttribute tokenize(const AtomicString&);

This probably doesn't need to be an AtomicString.  You're using
equalIgnoringCase, so the atomicity isn't really helping.

> Source/WebCore/loader/LinkLoader.h:45
> +/* The LinkLoader can load link rel types icon, dns-prefetch, subresource,
prefetch and prerender
> + */

C++ style comments pls.