[webkit-reviews] review denied: [Bug 62027] nrwt: handle missing httpd cleanly : [Attachment 97420] proposed fix

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Kristóf Kosztyó
<Kosztyo.Kristof at stud.u-szeged.hu>'s request for review:
Bug 62027: nrwt: handle missing httpd cleanly
https://bugs.webkit.org/show_bug.cgi?id=62027

Attachment 97420: proposed fix
https://bugs.webkit.org/attachment.cgi?id=97420&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97420&action=review

Almost there.

> Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py:210
> +	   if not(os.system(self._start_cmd + " -v >" + os.devnull)):

Generally speaking we try to avoid calling routines in os.* directly where
possible, and this will also have the side effect of printing stuff to stderr,
which I try to avoid.

Can you change this to:

try:
     return self._port_obj._executive(self._start_cmd + " -v",
return_error_code=True):
except OSError, e:
     return False

instead?

> Tools/Scripts/webkitpy/layout_tests/port/base.py:191
> +	   self.check_httpd()

This check only needs to be done if needs_http is true.