[webkit-reviews] review denied: [Bug 61042] [Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests : [Attachment 97491] Forces icon to be loaded on each test by setting a temporary path for them, and making test to wait for the iconChange signal.

[bugzilla-daemon at webkit.org]

Alexis Menard <alexis.menard at openbossa.org> has denied Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 61042: [Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav()
autotests
https://bugs.webkit.org/show_bug.cgi?id=61042

Attachment 97491: Forces icon to be loaded on each test by setting a temporary
path for them, and making test to wait for the iconChange signal.
https://bugs.webkit.org/attachment.cgi?id=97491&action=review

------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97491&action=review

You posted an unrelated patch :D.

> Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:-165
> -    QWebSettings::enablePersistentStorage(tmpDir());

Why this move?

> Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:172
> +    ::waitForSignal(wv, SIGNAL(iconChanged()), 15000);

By curiosity why ::?