[webkit-reviews] review granted: [Bug 62066] XHRs and preloads cause DocumentLoader::isLoadingInAPISense() to return true : [Attachment 97480] Fix Windows Build. Again.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 62066: XHRs and preloads cause DocumentLoader::isLoadingInAPISense() to
return true
https://bugs.webkit.org/show_bug.cgi?id=62066

Attachment 97480: Fix Windows Build. Again.
https://bugs.webkit.org/attachment.cgi?id=97480&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97480&action=review

> LayoutTests/http/tests/loading/preload-append-scan.php:15
> +    var result;
> +    if (internals.isPreloaded("resources/preload-test.jpg"))

Should we check for the existence of window.internals before using it?

> Source/WebCore/testing/Internals.h:46
> +    Frame* m_frame;

Is there a risk of this pointer becoming garbage since Internals is refcounted
and could out-live Frame?